runner: Convert idle-timeout="never" to 0 with GitLab driver (#1408)

* runner: Convert idle-timeout="never" to 0 with GitLab driver GitLab runners do not support "never" as an argument for --wait-timeout, instead this should be 0, which by default is no timeout. Fixes #1407 * Fix linting error * Update src/drivers/gitlab.js --------- Co-authored-by: Daniel Barnes <[email protected]>
iterative · Jul 28, 2023 · b64044f · b64044f
1 parent cbd84c4
commit b64044f
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/drivers/gitlab.js b/src/drivers/gitlab.js
@@ -200,6 +200,11 @@ class Gitlab {
       const { protocol, host } = new URL(this.repo);
       const { token } = await this.registerRunner({ tags: labels, name });
 
+      let waitTimeout = idleTimeout;
+      if (idleTimeout === 'never') {
+        waitTimeout = '0';
+      }
+
       let dockerVolumesTpl = '';
       dockerVolumes.forEach((vol) => {
         dockerVolumesTpl += `--docker-volumes ${vol} `;
@@ -210,7 +215,7 @@ class Gitlab {
         --url "${protocol}//${host}" \
         --name "${name}" \
         --token "${token}" \
-        --wait-timeout ${idleTimeout} \
+        --wait-timeout ${waitTimeout} \
         --executor "${IN_DOCKER ? 'shell' : 'docker'}" \
         --docker-image "iterativeai/cml:${gpu ? 'latest-gpu' : 'latest'}" \
         ${gpu ? '--docker-runtime nvidia' : ''} \