Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/ec2-debug-and-manual-cleanup #240

Merged
merged 7 commits into from
May 23, 2022
Merged

docs/ec2-debug-and-manual-cleanup #240

merged 7 commits into from
May 23, 2022

Conversation

evamaxfield
Copy link
Contributor

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

Associated with: iterative/cml#1006
cc @dacbd

Further sidenote: If someone can tell me the exact IAM permissions required for the bare minimum EC2 runner to spin up, I would happily add that in this PR too.

@dacbd dacbd self-assigned this May 16, 2022
@dacbd
Copy link
Contributor

dacbd commented May 16, 2022

I plan to merge this with mine that's still a draft (because I plan to stop procrastinating on it soon...)

@iterative/cml thoughts on the messaging? (I can incorporate the feedback and collapse this PR in with mine linked above.)

@JacksonMaxfield I have copied the below from an old message on our discord server.

ec2:AuthorizeSecurityGroupEgress    - Create firewall rule
ec2:AuthorizeSecurityGroupIngress   - Create firewall rule
ec2:CancelSpotInstanceRequests      - if using spot
ec2:CreateSecurityGroup             - Create virtual firewall rule to allow ssh
ec2:CreateTags                      - resource management
ec2:DeleteKeyPair                   - clean up created ssh key
ec2:DescribeImages                  - Searching from CML providied AMIs
ec2:DescribeInstances               - Select created instance
ec2:DescribeSecurityGroups          - Select Security Group
ec2:DescribeSpotInstanceRequests    - if using spot
ec2:DescribeSubnets                 - Select Subnet for instance
ec2:DescribeVpcs                    - Assigning instance to correct VPC
ec2:ImportKeyPair                   - Creating SSH connection for server setup
ec2:RequestSpotInstances            - if using spot
ec2:RunInstances                    - Start created instance
ec2:TerminateInstances              - tear down when done

@evamaxfield
Copy link
Contributor Author

Thanks for the info! That is very useful!

Not quite following your sentence, can I add that table / list to this PR or are you going to take this PR and shove it into the existing draft PR of yours? Happy with either.

@dacbd dacbd changed the base branch from master to runner-improvements May 16, 2022 21:45
@dacbd
Copy link
Contributor

dacbd commented May 16, 2022

Thanks for the info! That is very useful!

Not quite following your sentence, can I add that table / list to this PR or are you going to take this PR and shove it into the existing draft PR of yours? Happy with either.

@JacksonMaxfield feel free to make edits and improvements here, what I mean is: If there are conflicts with the other branch I mentioned, I will fix them 😅

@dacbd dacbd requested a review from casperdcl May 16, 2022 22:02
@evamaxfield
Copy link
Contributor Author

Resolved comments and added the IAM permissions section 👍

@casperdcl casperdcl requested a review from 0x2b3bfa0 May 17, 2022 11:22
@casperdcl casperdcl added the documentation Markdown files label May 17, 2022
@dacbd dacbd merged commit 18103b8 into iterative:runner-improvements May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Markdown files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants