Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placate trunk by providing a <body> tag, remove icons from cards example #45

Merged
merged 2 commits into from
Sep 8, 2024
Merged

Placate trunk by providing a <body> tag, remove icons from cards example #45

merged 2 commits into from
Sep 8, 2024

Conversation

micolous
Copy link
Contributor

@micolous micolous commented Sep 8, 2024

1 commit is also in #44.

Fixes an issue building the basics, cards and forms examples with recent versions of trunk:

error from build pipeline

Caused by:
    0: HTML build pipeline failed (1 errors), showing first
    1: failed to finalize asset pipeline
    2: Document has neither a <link data-trunk rel="rust"/> nor a <body>. Either one must be present.

The icons example already builds fine.

While here, remove Bootstrap Icons from the cards example, because it is never used, and include_cdn_icons() is deprecated.

@micolous micolous mentioned this pull request Sep 8, 2024
Draft
@isosphere isosphere merged commit fa26063 into isosphere:main Sep 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micolous @isosphere