-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Progress and ProgressBar components #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for another contribution!
While I agree with error checking, I don't love being a library that panic!
s when bounds are exceeded. This could conceivably happen if the value is bound and modified to be out of bounds. I think I'd rather we clamp the value to be max if it's above max and ditto for min and complain with a console error somewhere. The entire Yew application we provide components for shouldn't crash for this kind of violation.
Ok I think you're right. I tried to not change the values as much as possible except to avoid the div to panic. |
I agree! That's a pretty common dependency, I think it's reasonable for us to depend on it so we can provide better debugging info. |
Values are unchanged except for divide operation.
log::warn is not visible for a Web application
I added a commit to change log::warn to gloo_console::warn. |
Thanks for the adjustment; merged with main as 0.9.0. I feel the bump in minor version coveys the new feature supported better. |
In line with https://getbootstrap.com/docs/4.0/components/progress/