Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ipni checks #66

Merged
merged 11 commits into from
Sep 19, 2024
Merged

feat: add ipni checks #66

merged 11 commits into from
Sep 19, 2024

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Sep 13, 2024 •
edited
Loading

  • feat: add config input for IPNI indexer
  • feat: query ipni indexer on ipfs-check test

Note: This PR is still in progress and currently only outputs results of the indexer check to the console.

Next steps

  • Agree upon the format of the output on the website
  • Implement the output on the website
  • Add tests for the new functionality
  • Add documentation for the new functionality

Fixes #65

SgtPooki
SgtPooki commented Sep 13, 2024
View reviewed changes
Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still some commented out code to cleanup

ipni.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
2color
2color reviewed Sep 16, 2024
View reviewed changes
main.go Outdated Show resolved Hide resolved
aschmahmann
aschmahmann requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests will help flush out if things are properly covered here, but generally looks good aside from a few comments I made.

daemon.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
daemon.go Outdated Show resolved Hide resolved
@gammazero gammazero marked this pull request as ready for review September 17, 2024 22:22
aschmahmann
aschmahmann requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 comment, but otherwise LGTM

daemon.go Outdated Show resolved Hide resolved
aschmahmann
aschmahmann reviewed Sep 18, 2024
View reviewed changes
web/index.html Outdated Show resolved Hide resolved
@gammazero
Peer check determines if cid is found in both IPNI and DHT
6a968b9 
Return HTTP 400 Bad Request error if user-supplied multiaddr is not valid.
@gammazero
Do not mask error
31acb13
aschmahmann
aschmahmann requested changes Sep 19, 2024
View reviewed changes
daemon.go Outdated Show resolved Hide resolved
web/index.html Outdated Show resolved Hide resolved
@gammazero gammazero merged commit 6e3c677 into ipfs:main Sep 19, 2024
11 checks passed
2color
2color reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@2color 2color left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel left review comments

@2color 2color 2color left review comments

@gammazero gammazero gammazero left review comments

@aschmahmann aschmahmann aschmahmann requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add IPNI checks
5 participants
@SgtPooki @lidel @2color @aschmahmann @gammazero