Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authentication bug with httpx usage #289

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

c0llab0rat0r
Copy link
Contributor

And:

  • add status_code property to StatusError class
  • change PartialErrorResponse to inherit from Error instead of ErrorResponse due to lack of success status code availablilty at call site throwing PartialErrorResponse

This PR is an alternative to #285.

… to StatusError class; change PartialErrorResponse to inherit from Error instead of ErrorResponse due to lack of status code
@c0llab0rat0r c0llab0rat0r changed the title Fix authentication bug with httpx usage bug Fix authentication bug with httpx usage Jun 30, 2021
@c0llab0rat0r
Copy link
Contributor Author

@ntninja this is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant