Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(angular): upgrade to v18 #1814

Merged
merged 8 commits into from
Jun 3, 2024
Merged

chore(angular): upgrade to v18 #1814

merged 8 commits into from
Jun 3, 2024

Conversation

thetaPC
Copy link
Contributor

@thetaPC thetaPC commented May 31, 2024

The app was on Angular v16, and this PR upgrades it to v18.

@@ -60,7 +60,7 @@ export class AppComponent implements OnInit {
this.checkLoginStatus();
this.listenForLoginEvents();

this.swUpdate.available.subscribe(async res => {
this.swUpdate.versionUpdates.subscribe(async res => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

available became deprecated and replaced with versionUpdates.

@thetaPC thetaPC marked this pull request as ready for review June 3, 2024 20:53
@thetaPC thetaPC merged commit 330cc00 into main Jun 3, 2024
2 checks passed
@thetaPC thetaPC deleted the angular-18-official branch June 3, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants