Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parsing for vat_rate and address fields. Added static partner name field #556

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Apr 25, 2024

This PR adds fields for VAT rate, address and partner name for Pepephone invoices.

Copy link
Collaborator

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you want to include the CIF: in the parsed address

@esteve
Copy link
Contributor Author

esteve commented Apr 25, 2024

@bosd pdftotext extracts it all in one line like this:

PEPEMOBILE S.L.Registro Mercantil de Madrid, Tomo 24.019, Libro 0, Folio 108, Sección 8, Hoja M-431409 e Inscripción 10ª. CIF: ESB85033470 Avda de Bruselas, num. 38,  
28108 Alcobendas, Madrid. España

I've used the CIF to find that line, but the capture group only takes the address.

@bosd
Copy link
Collaborator

bosd commented Apr 25, 2024

Thanks, now I understand

@bosd bosd merged commit 0c99832 into invoice-x:master Apr 25, 2024
5 checks passed
@esteve esteve deleted the add-fields-pepephone branch April 25, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants