Provide Invoice2Data class for object oriented usage #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rmilecki
commented
Feb 19, 2023
rmilecki
commented
|
I was wondering if there is any interest in providing an That idea originally came from #392 but maybe it could be a generic improvement. |
This will allow using invoice2data in an object oriented way like:
import invoice2data
i2d = invoice2data.Invoice2Data()
i2d.extract_data("foo.pdf")
Signed-off-by: Rafał Miłecki <[email protected]>
|
Sounds good. So the class would be instantiated with some templates and then read invoices? Makes sense, since we already keep some state via templates and the input source. |
|
I'd still carefully consider which objects make sense. Maybe you also want an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.