Fixed one test and used an env var for the google cloud bucket #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bucket name will be given as an environment variable as the method to_text() is only given one argument when used in extract_data
|
I don't think we want to remove the function argument altogether. |
|
Note token. I removed the "default" option of the Google Cloud bucket name as it needs to be changed anyway by a new user (now defaults to None). Now, it can either be an argument, or an environment variable (depends on application). Can now be in a docker. |
rakshithrs
approved these changes
Jan 2, 2021
rakshithrs
approved these changes
Jan 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bucket name will be given as an environment variable as the method to_text() is only given one argument when used in extract_data().
The fixed test was using the wrong file extension to compare the results. Therefore, the test would not pass.