Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement reading and setting default values #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implement reading and setting default values #34

wants to merge 2 commits into from

Conversation

duskybomb
Copy link

Reading and set default if value is not defined

  • What all fields can have _default?
  • Should I add as many fields as possible to fields.yml?

@m3nu
Copy link
Collaborator

m3nu commented Jul 3, 2018

Tests and actual default values?

@duskybomb
Copy link
Author

For tests, we need to resolve issue with _required fields (whether name and LineTotalAmount are required fields or not), because else is_valid() will always return False[1]. It is also affecting other features and tests as well.

@duskybomb
Copy link
Author

What all fields can have default values?

@duskybomb
Added tests
78bc5d0 
 - to check default values
Corrected test
 - write pdf
 - write xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duskybomb @m3nu