Skip to content
This repository has been archived by the owner on Feb 4, 2021. It is now read-only.

Update ripple polyfil to support flex on the touchable #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mlabrum
Copy link
Contributor

@mlabrum mlabrum commented Jul 28, 2016

Hey,

I found that on IOS the TouchableOpacity won't respect the child flex (where TouchableNativeFeedback seems to) and that it sometimes requires a kick to force it to flex

pre flex
touchable-pre

after flex
touchable-after

(Trying to make the whole area a button)

@Salakar
Copy link
Member

Salakar commented Sep 2, 2016

Could we not use the existing style prop to pass this along - Incase other styles other than flex are wanted? Thoughts?

@mlabrum
Copy link
Contributor Author

mlabrum commented Sep 6, 2016

the existing style prop updates the inner and outer View within the IOS TouchableOpacity, I needed to be able to set styles directly on the outer container of TouchableOpacity, to be able to get the flex needed

We could adjust this to be a generic touchableOpacityStyles prop?

@dantman
Copy link
Contributor

dantman commented Feb 9, 2017

Better innerStyle/outerSyle handling that works the same with and without the polyfill would be better.

@CLAassistant
Copy link

CLAassistant commented Jul 11, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants