Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps)!: mobile ads sdk upgrade - ios 11.0.1, ump sdk 2.2.0 #551

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

dylancom
Copy link
Collaborator

Description

BREAKING CHANGES:

  • The SDK no longer depends directly on GoogleAppMeasurement. To continue collecting user metrics in AdMob, link your AdMob app to Firebase and integrate the Google Analytics for Firebase SDK into your app.
  • Updated the minimum supported Xcode version to 15.1.
  • Increased iOS minimum deployment target to 12.0.
  • Updated the minimum OS required to receive ads to iOS 13.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Merging #551 (d1b88b2) into main (7aef863) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #551   +/-   ##
=======================================
  Coverage   43.66%   43.66%           
=======================================
  Files          29       29           
  Lines         536      536           
  Branches      147      147           
=======================================
  Hits          234      234           
  Misses        302      302           

@dylancom dylancom merged commit d924586 into main Feb 22, 2024
12 of 13 checks passed
@dylancom dylancom deleted the feature/upgrade-sdk branch February 22, 2024 09:20
@mikehardy
Copy link
Collaborator

🎉 This PR is included in version 13.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@@ -17,7 +17,7 @@ Pod::Spec.new do |s|
s.authors = "Invertase Limited"
s.source = { :git => "#{package["repository"]["url"]}.git", :tag => "v#{s.version}" }
s.social_media_url = 'http://twitter.com/invertaseio'
s.ios.deployment_target = "10.0"
s.ios.deployment_target = "12.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dylancom - as long as you've got a breaking change you might do a 13.0.1 that adds one more break. In order to support app privacy manifests (which will be an Apple requirement shortly), cocoapods has to be at >= 1.12.0

This is how I did it for react-native-firebase, soon to release

  s.cocoapods_version   = '>= 1.12.0'

invertase/react-native-firebase@2cf4e4d#diff-14af2ce820d14cb75e1bde06b65a88dd9c151e9054418d2486dc35eaa3c1e69e

Also we may need to document a specific switch to toggle on in their Podfile for @react-native-firebase/analytics most people using AdMob will want, from a PR I'm going to merge shortly

$RNFirebaseAnalyticsEnableAdSupport = true

This links in the AdSupport framework from Apple which Firebase Analytics detects and enables the collection of optional demographic information invertase/react-native-firebase#7637

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants