Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ios): note that pod install is required to see ios_config.sh changes #550

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

mikehardy
Copy link
Collaborator

Description

This wastes developer's time, we should warn them

Related issues

Related:

Release Summary

docs only, no release

Checklist

  • I read the Contributor Guide
    and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in __tests__e2e__
    • jest tests added or updated in __tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

No tests needed, all comments


Think react-native-google-mobile-ads is great? Please consider supporting the project with any of the below:

  • 👉 Star this repo on GitHub ⭐️
  • 👉 Follow Invertase on Twitter

…nges

This wastes developer's time, we should warn them
@mikehardy mikehardy added the workflow: pending merge Waiting on CI or question responses to merge, but otherwise ready label Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Merging #550 (f7bee6c) into main (7aef863) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #550   +/-   ##
=======================================
  Coverage   43.66%   43.66%           
=======================================
  Files          29       29           
  Lines         536      536           
  Branches      147      147           
=======================================
  Hits          234      234           
  Misses        302      302           

@mikehardy
Copy link
Collaborator Author

This is in place in react-native-firebase, no issues

@mikehardy mikehardy merged commit ebd8f79 into main Feb 26, 2024
13 checks passed
@mikehardy
Copy link
Collaborator Author

(it will trigger a project.pbxproj change in the example project on next example project pod install)

@mikehardy mikehardy removed the workflow: pending merge Waiting on CI or question responses to merge, but otherwise ready label Feb 26, 2024
@mikehardy mikehardy deleted the @mikehardy/ios-config-warning branch February 26, 2024 12:32
@mikehardy
Copy link
Collaborator Author

🎉 This PR is included in version 13.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant