feat!: Update Firebase iOS SDK version to v11 #8028
+3
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change since the minimum version of iOS and macOS has changed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Upstream firestore-ios-sdk-frameworks issue is fixed and the Firestore binary distribution now directly depends on nanopb as it should, so we should remove the workaround here. This tangentially fixes compile of InAppMessaging which was specifying a mutually exclusive nanopb version range
firebase-ios-sdk v11+ removed one of the parameters from their component initialization API, we must remove it here to use firebase-ios-sdk v11+
mikehardy
reviewed
Sep 19, 2024
There was a problem hiding this comment.
oh darn - I was hoping this was non-breaking but forgot about the bumps to the min supported version on platforms, quite right on that one
podspecs and docs may not be inline with regards to minimums speced in podfile and/or described as supported in docs - haven't scanned
code may have @available branches that are no longer applicable as new minimum means previous checked ver is always available, could use a grep for available perhaps
test app may need xcproj update to change min supported ?
that's all I can think of as those things bump...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change since the minimum version of iOS and macOS has changed
Description
Related issues
Release Summary
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter