Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n: Fixes strings marked for translation. #522

Merged
merged 1 commit into from
Jun 9, 2022
Merged

i18n: Fixes strings marked for translation. #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/lib/components/Funding/FundingModal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ const StandardSchema = Yup.object().shape({
const CustomFundingSchema = Yup.object().shape({
selectedFunding: Yup.object().shape({
funder: Yup.object().shape({
id: Yup.string().required(i18next.t('Funder is required')),
id: Yup.string().required(i18next.t('Funder is required.')),
}),
award: Yup.object().shape({
title: Yup.string().test({
name: 'testTitle',
message: i18next.t('Title must be set alongside number'),
message: i18next.t('Title must be set alongside number.'),
test: function testTitle(value) {
const { number } = this.parent;

Expand All @@ -68,7 +68,7 @@ const CustomFundingSchema = Yup.object().shape({
}),
number: Yup.string().test({
name: 'testNumber',
message: i18next.t('Number must be set alongside title'),
message: i18next.t('Number must be set alongside title.'),
test: function testNumber(value) {
const { title } = this.parent;

Expand All @@ -80,7 +80,7 @@ const CustomFundingSchema = Yup.object().shape({
},
}),
url: Yup.string()
.url(i18next.t('Url Must be a valid url'))
.url(i18next.t('Url must be a valid url.'))
.test({
name: 'validateUrlDependencies',
message: i18next.t('Url must be set alongside title and number.'),
Expand Down
4 changes: 2 additions & 2 deletions src/lib/components/PublishButton/SubmitReviewModal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export class SubmitReviewModal extends Component {
<p>
<Icon name="warning sign" />
{i18next.t(
'Before requesting review please read and check the following.'
'Before requesting review please read and check the following:'
)}
</p>
</Message>
Expand Down Expand Up @@ -118,7 +118,7 @@ export class SubmitReviewModal extends Component {
fieldPath="acceptAfterPublishRecord"
label={
<Trans
defaults="If your upload is accepted by the community curators, it will be <bold> immediately published.</bold> Before that, you will still be able to modify metadata and files of this uploads."
defaults="If your upload is accepted by the community curators, it will be <bold>immediately published</bold>. Before that, you will still be able to modify metadata and files of this upload."
values={{
communityTitle: communityTitle,
}}
Expand Down