templates: page_cover: Add banner to login template #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzacharo
reviewed
Sep 2, 2024
| @@ -13,6 +13,11 @@ | |||
|
|
|||
| {%- block body %} | |||
| <div class="sixteen wide column centered"> | |||
| {%- block site_banner %} | |||
| {% from 'invenio_banners/banner.html' import banner %} | |||
There was a problem hiding this comment.
I don't think there is a direct dependency on invenio-banners in this module...I think it is better to either keep the block here and implement the banner in a "higher" level module or completely move this to another module where it depends on invenio-banners.
zzacharo
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: CERNDocumentServer/cds-rdm#190