Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(UI) Publish buttons: refactored isDisabled function #1808

Merged
merged 2 commits into from
Sep 3, 2024
Merged

(UI) Publish buttons: refactored isDisabled function #1808

merged 2 commits into from
Sep 3, 2024

Commits on Sep 3, 2024

  1. controls: refactored isDisabled function 

    * Refactored isDisabled function in PublishButton and SubmitReviewButton components to check if all files are finished uploading before enabling the button.
* Passed filesState instead of just the number of files to the function.
* Added a check for non-finished files.
* Added early returns to avoid unnecessary checks on possible large objects / arrays.
    @alejandromumo
    alejandromumo committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    1eead8d View commit details
    Browse the repository at this point in the history

  2. chore: fix eslint errors

    @alejandromumo
    alejandromumo committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    4536c1a View commit details
    Browse the repository at this point in the history