I18N: Collecting issues found while translating de

[chriz-uniba]

Subissue of #1664

This is an issue to collect several issues related to translating the invenioRDM-instance. I will try to branch out from here and create PRs or issues in the respective packages.

Cutting Strings

In all the following cases the translation was cut into substrings. This is problematic because:

• the word order in other languages does not always stay the same as the English one.

• in transifex it is hard to figure out that three substrings will eventually build one string.

• in transifex it is hard to see trailing whitespaces and whether they are needed.

• Issue: i18n: Improvement of strings marked for translation needed #1718

  • invenio-app-rdm/invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/search/components.js

    Lines 411 to 412 in 484ba92

    	{i18next.t("We couldn't find any matches for ")}
    	{(queryString && `'${queryString}'`) || i18next.t("your search")}

  • invenio-app-rdm/invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/search/components.js

    Lines 442 to 446 in 484ba92

    	{i18next.t("For more tips, check out our ")}
    	<a href="/help/search" title={i18next.t("Search guide")}>
    	{i18next.t("search guide")}
    	</a>
    	{i18next.t(" for defining advanced search queries")}.

  • invenio-app-rdm/invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/search/components.js

    Lines 431 to 439 in 484ba92

    	<a
    	href={`${searchPath}?q=metadata.publication_date:[2017-01-01 TO *]`}
    	>
    	metadata.publication_date:[2017-01-01 TO *]
    	</a>{" "}
    	{i18next.t(
    	"will give you all the publications from 2017 until today"
    	)}
    	.

• Issue: i18n: Improvement of string marked for translation needed react-invenio-deposit#524

  • https://github.com/inveniosoftware/react-invenio-deposit/blob/de12453ea2121c69b9cd629e46f11fbfdb7725bd/src/lib/components/FileUploader/FileUploader.js#L109-L115

• Issue: i18n: Improvement of string marked for translation needed invenio-accounts#417

  • https://github.com/inveniosoftware/invenio-accounts/blob/89632b0179fce038f584311a19ed8950904634d9/invenio_accounts/templates/security/email/change_notice_rest.html#L3

• https://github.com/inveniosoftware/invenio-requests/blob/master/invenio_requests/assets/semantic-ui/js/invenio_requests/timelineEvents/timelineActionEvents.js

  • 
  • <name><message><time>
  • WORKAROUND: I guess we can deal with this one

Probably this way of marking translations would fix (some) of them?

• https://github.com/inveniosoftware/invenio-communities/blob/2da66f3c478c7745b6fbcaee2b0b48d26523f58c/invenio_communities/assets/semantic-ui/js/invenio_communities/members/invitations/invitationsModal/GroupTabPane.js#L115-117
• See also: https://inveniordm.docs.cern.ch/develop/best-practices/i18n/ (search for Trans)
  Comments by @kpsherva:
• https://react.i18next.com/latest/trans-component
• there are also examples in the code with something like i18next.t("ABC {{ not_translatable_variable }} rest of the string", {not_translatable_variable: 7}) it might be also useful to see

Coding-Translation-Issues

• Included in this issue: i18n: Improvement of string marked for translation needed react-invenio-deposit#524

  • https://github.com/inveniosoftware/react-invenio-deposit/blob/de12453ea2121c69b9cd629e46f11fbfdb7725bd/src/lib/components/FileUploader/FileUploaderToolbar.js#L73-L75

  • 

  • 0 bytes aus 10.00 Gb

  • in German it would be "Bytes" instead of "bytes"!

• Embargo - hopefully fixed by: Date not refreshed in embargoed message react-invenio-deposit#561
  

  • https://github.com/inveniosoftware/react-invenio-deposit/blob/aa2c09b808b95f014ebf267f118f53476ae72956/src/lib/components/Access/EmbargoedMetadataOnly.js#L45
  • the date is not "German"
  • might be the case because my browser is set to English - but invenio was set to German?

• invenio-app-rdm/invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/user_dashboard/requests.js

  Line 159 in e8256a0

  const differenceInDays = timestampToRelativeTime(createdDate.toISOString());

  • is this used here? (2 minutes ago)
    • 
    • <name><message><time>
    • might be false alarm - probably not checked in German instance yet.

Dot after translation-mark / Missing dot / Really dot?

invenio-app-rdm

• invenio-app-rdm/invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/search/components.js

  Lines 431 to 439 in 484ba92

  	<a
  	href={`${searchPath}?q=metadata.publication_date:[2017-01-01 TO *]`}
  	>
  	metadata.publication_date:[2017-01-01 TO *]
  	</a>{" "}
  	{i18next.t(
  	"will give you all the publications from 2017 until today"
  	)}
  	.

• 
• 

invenio-accounts

• https://github.com/inveniosoftware/invenio-accounts/blob/89632b0179fce038f584311a19ed8950904634d9/invenio_accounts/templates/security/email/change_notice_rest.html#L3

invenio-communities

• https://github.com/inveniosoftware/invenio-communities/blob/2da66f3c478c7745b6fbcaee2b0b48d26523f58c/invenio_communities/communities/services/components.py#L113
• https://github.com/inveniosoftware/invenio-communities/blob/37b7e99431a79717769d74e03ed4fff0c33a1349/invenio_communities/members/services/schemas.py#L82
• https://github.com/inveniosoftware/invenio-communities/blob/master/invenio_communities/assets/semantic-ui/js/invenio_communities/members/members/index.js
• https://github.com/inveniosoftware/invenio-communities/blob/2da66f3c478c7745b6fbcaee2b0b48d26523f58c/invenio_communities/members/services/service.py#L258
• https://github.com/inveniosoftware/invenio-communities/blob/2da66f3c478c7745b6fbcaee2b0b48d26523f58c/invenio_communities/members/services/service.py#L483
• https://github.com/inveniosoftware/invenio-communities/blob/2da66f3c478c7745b6fbcaee2b0b48d26523f58c/invenio_communities/assets/semantic-ui/js/invenio_communities/settings/profile/RenameCommunitySlugButton.js#L92
• https://github.com/inveniosoftware/invenio-communities/blob/2da66f3c478c7745b6fbcaee2b0b48d26523f58c/invenio_communities/assets/semantic-ui/js/invenio_communities/members/components/RemoveMemberModal.js#L41
• https://github.com/inveniosoftware/invenio-communities/blob/2da66f3c478c7745b6fbcaee2b0b48d26523f58c/invenio_communities/assets/semantic-ui/js/invenio_communities/members/invitations/invitationsModal/GroupTabPane.js#L116
• 

invenio-vocabularies

• https://github.com/inveniosoftware/invenio-vocabularies/blob/e763130b4dee931db8aec6b290685e48c4451644/invenio_vocabularies/contrib/subjects/schema.py#L48

invenio-rdm-records

• https://github.com/inveniosoftware/invenio-rdm-records/blob/e460ffa92aea052d7e9db1799e30e6971d8f10b3/invenio_rdm_records/oaiserver/services/services.py#L71
• https://github.com/inveniosoftware/invenio-rdm-records/blob/d25e3670b74f132390fc42e5647765ae5c605ef3/invenio_rdm_records/oaiserver/services/services.py#L79

react-invenio-deposit

• https://github.com/inveniosoftware/react-invenio-deposit/blob/master/src/lib/components/Funding/FundingModal.js
• 
  • colon?
• 
  • dot part of strong

invenio-previewer

• https://github.com/inveniosoftware/invenio-previewer/blob/bf6fb82fb326f56a61428f620d814c6a4d901c05/invenio_previewer/templates/semantic-ui/invenio_previewer/zip.html#L29

Inconsistencies

react-invenio-deposit

• https://github.com/inveniosoftware/react-invenio-deposit/blob/de12453ea2121c69b9cd629e46f11fbfdb7725bd/src/lib/components/FileUploader/FileUploaderArea.js#L280
  • misses "-": metadata-only
  • 
• 
  • make it "Drag and drop files" --- remove the "()"
• 
  • https://github.com/inveniosoftware/react-invenio-deposit/blob/a18cc7eaf741a3734e9f270b8d456ae484bce748/src/lib/translations/messages/en/translations.json#L50-L51
  • make it "Given names"
• Identifier(s)
• https://github.com/inveniosoftware/react-invenio-deposit/blob/a18cc7eaf741a3734e9f270b8d456ae484bce748/src/lib/components/PublisherField.js#L45
  • 
  • "enter" not used often - not needed

invenio-rdm-records

• https://github.com/inveniosoftware/invenio-rdm-records/blob/d25e3670b74f132390fc42e5647765ae5c605ef3/invenio_rdm_records/oaiserver/services/services.py#L79
  • consistent use of 'must'
  • 
  • make it the same
  • 
  • 
• 
  • shoud / must

invenio-communities

• https://github.com/inveniosoftware/invenio-communities/blob/2da66f3c478c7745b6fbcaee2b0b48d26523f58c/invenio_communities/assets/semantic-ui/js/invenio_communities/settings/profile/RenameCommunitySlugButton.js#L92
  • "enter" not used often - not needed
• 
  • whitespace
• 
• You are only here used "You’re"

invenio-app-rdm

• 
  • make it "Alternate identifiers"

Unsorted

• Username vs. user name --- in all invenioRDM repos it seems to be "Username"

• pid PID Pid... in vocabularies
  

  • PIDS seems not be used?
    

• url Url URL --- should be URL

• Issue: Standardising on the terms "record" and "upload" #1822

  • record vs. upload
  • among others
    

Bug

• https://github.com/inveniosoftware/invenio-accounts/blob/21ea08bae4c711d684c5005a810f04eb6faf651a/invenio_accounts/utils.py#L209
  • “ACCOUNTS_USERNAME_RULES_TEXT”
  • https://discord.com/channels/692989811736182844/704625518552547329/981478183486509056

Meaning / Fixing info-messages

• 
  • "include it in publication drafts"?
• 
  • https://github.com/inveniosoftware/invenio-vocabularies/blob/e763130b4dee931db8aec6b290685e48c4451644/invenio_vocabularies/contrib/names/schema.py#L51
  • programmers info or user info?
• 
  • What is the "draft version"?

Others

• 
  • lower case "must" - fixed
  • Url url
  • wording
• 
  • really click?

Translation Context

• https://github.com/inveniosoftware/invenio-users-resources/blob/cce2a1bb4593c75a43d9c41bafa6883ba08f32e7/invenio_users_resources/services/schemas.py#L21
  • programmers info or user info?
  • is it public/restricted as reserved key-words?
  • message=str(_("Value must be either 'public' or 'restricted'."))
  • ANSWER in principal this should only be seen by an api-user or developer - for them public and restricted are key-words, for a gui-user these key-words are translated.
• https://github.com/inveniosoftware/invenio-communities/blob/37b7e99431a79717769d74e03ed4fff0c33a1349/invenio_communities/members/services/schemas.py#L82
  • What is 'role' and 'visible' referring at?
  • raise ValidationError(_("Missing fields 'role' and/or 'visible'"))
  • ANSWER I guess this is the same as with 'public'/'restricted' above.
• https://github.com/inveniosoftware/invenio-files-rest/blob/f9c7266876230b9e8f41e8dfac41fc67b9896fe6/invenio_files_rest/admin.py#L34
  • What is 'location' in this context?
  • DISCUSSION https://discord.com/channels/692989811736182844/704625518552547329/1003597577662500894
• https://github.com/inveniosoftware/invenio-rdm-records/blob/e460ffa92aea052d7e9db1799e30e6971d8f10b3/invenio_rdm_records/oaiserver/services/services.py#L71
  • What is "spec" in this context?
  • WORKAROUND: leave the word spec in the translation
• https://github.com/inveniosoftware/invenio-communities/blob/37b7e99431a79717769d74e03ed4fff0c33a1349/invenio_communities/members/services/service.py#L167
  • programmers info or user info?
  • raise ValidationError(_("Must be false"))
  • DISCUSSION: https://discord.com/channels/692989811736182844/704625518552547329/1003600889434615818

[chriz-uniba]

The collection and fixing is over: all ongoing problems have their own issue and will be further followed there:

• Standardising on the terms "record" and "upload": Standardising on the terms "record" and "upload" #1822
• cutting of string-to-translate
  • i18n: Improvement of strings marked for translation needed #1718
  • i18n: Improvement of string marked for translation needed invenio-accounts#417
  • i18n: Improvement of string marked for translation needed react-invenio-deposit#524
    (includes bytes vs Bytes)

Therefore, I will close this issue.