Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains: Add uniqueness constraint and tests for DomainCategory model and CLI #489

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Samk13
Copy link
Member

@Samk13 Samk13 commented Aug 21, 2024

❤️ Thank you for your contribution!

Description

  • Added unique=True constraint to the label field in DomainCategory model to enforce uniqueness at the database level.
  • Modified domains_create CLI command to check for duplicates before creating a new domain category, providing feedback if the domain already exists.
  • Added tests for DomainCategory model to validate creation, retrieval, and handling of duplicate labels.
  • Enhanced test_cli_createdomain
  • closes Duplicate Domain Creation Allowed Without Validation invenio-app-rdm#2796

image

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

* Added `unique=True` constraint to the `label` field in `DomainCategory` model to enforce uniqueness at the database level.
* Modified `domains_create` CLI command to check for duplicates before creating a new domain category, providing feedback if the domain already exists.
* Added tests for `DomainCategory` model to validate creation, retrieval, and handling of duplicate labels.
* Enhanced `test_cli_createdomain`
* closes inveniosoftware/invenio-app-rdm#2796
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate Domain Creation Allowed Without Validation
1 participant