Merge pull request #205 from invenia/ox/cr1

bump ChainRules compat to v1
invenia · Jul 27, 2021 · 49bf7f5 · 49bf7f5 · oxinabox · Jul 27, 2021
2 parents 8d3dc2b + 6a10c22
commit 49bf7f5
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "Nabla"
 uuid = "49c96f43-aa6d-5a04-a506-44c7070ebe78"
-version = "0.13.0"
+version = "0.13.1"
 
 [deps]
 ChainRules = "082447d4-558c-5d27-93f4-14fc19e9eca2"
@@ -15,14 +15,14 @@ SpecialFunctions = "276daf66-3868-5448-9aa4-cd146d93841b"
 Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
 
 [compat]
-ChainRules = "0.8"
-ChainRulesCore = "0.10.9"
+ChainRules = "0.8, 1"
+ChainRulesCore = "0.10.9, 1"
 ChainRulesOverloadGeneration = "0.1.2"
 ExprTools = "0.1.4"
 FDM = "0.6.1"
 ForwardDiff = "0.10.12"
 SpecialFunctions = "1.5.1"
-julia = "^1.3"
+julia = "1.3"
 
 [extras]
 BenchmarkTools = "6e4b80f9-dd63-53aa-95a3-0cdb28fa8baf"

diff --git a/test/core.jl b/test/core.jl
@@ -167,7 +167,7 @@ end
 
 @testset "get_output" begin
     y = ∇(-, get_output=true)(2)
-    @test y isa Tuple{Branch{Int}, Tuple{Int}}
+    @test y isa Tuple{Branch{Int}, Tuple{Real}}
     @test last(y) == (-1,)
     @test ∇(unbox, get_output=true)(2) == (2, (0,))
 end

diff --git a/test/sensitivities/scalar.jl b/test/sensitivities/scalar.jl
@@ -79,8 +79,12 @@ end
         @test Y isa Branch{Vector{Float64}}
         @test unbox(Y) == Float64[1,2,3,4]
 
-        # In expressions
-        @test ∇(x->2x)(1) === (2,)
+        # In expressions.
         @test ∇(x->2*float(x))(1) === (2.0,)
+
+        # Note that actually float or no float out is the same as
+        # integers always have floating point derivatives
+        @test ∇(x->2x)(1) === (2.0,) 
+
     end
 end