Feat/add argon2 and kyber #1291
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deploying drive-web with
|
| Latest commit: |
4689dfe
|
| Status: | ⚡️ Build in progress... |
|
|
@TamaraFinogina Please provide a description |
| const messageHex = Buffer.from(message).toString('hex'); | ||
|
|
||
| // message should be the same length as secret, which is 256 bits | ||
| const xoredMessage = XORhex(messageHex, secretHex); |
There was a problem hiding this comment.
Will they always be the same length?
Maybe we should check in case they are not, so that it throws an error.
| try { | ||
| const publicKeyResponse = await userService.getPublicKeyByEmail(email); | ||
| publicKey = publicKeyResponse.publicKey; | ||
| publicKyberKey = publicKeyResponse.publicKyberKey; |
There was a problem hiding this comment.
the backend is already prepared to store this new key?
| isThereAnyNewUser = true; | ||
| } | ||
| usersList.push({ | ||
| email, | ||
| userRole, | ||
| isNewUser: !publicKey, | ||
| isNewUser: !publicKey || !publicKyberKey, |
There was a problem hiding this comment.
The user will have both keys always?
| }); | ||
|
|
||
| expect(encryptedMessage).toBeDefined(); | ||
| }); | ||
|
|
||
| it('xor should work', async () => { |
There was a problem hiding this comment.
It is too generic a test, separate it into different tests in which the description of what it has to achieve is a little more specific
| "editor.formatOnSave": true, | ||
| "editor.defaultFormatter": "esbenp.prettier-vscode", | ||
| "editor.codeActionsOnSave": { | ||
| "source.fixAll.eslint": "explicit", | ||
| "source.fixAll.format": "explicit" | ||
| }, | ||
| "svg.preview.background": "editor" | ||
| } |
There was a problem hiding this comment.
This has to be added to the gitignore, as it is part of the vs code configuration.
| "preinstall": "node scripts/use-yarn.js", | ||
| "prepare": "husky install", | ||
| "dev": "craco start", | ||
| "start": "craco start", | ||
| "build": "craco build", | ||
| "vercel:install": "yarn run add:npmrc && yarn install", | ||
| "test:unit": "jest src/ && jest test/unit", | ||
| "test:unit": "vitest run test/unit && vitest run src/ ", |
There was a problem hiding this comment.
Interesting change, with Vitest the problems with global meta variable has gone?
| }; | ||
| } | ||
| export function XORhex(a: string, b: string): string { |
There was a problem hiding this comment.
Maybe it would be good to add jsdoc for this function.
| let res = '', | ||
| i = a.length, | ||
| j = b.length; | ||
| while (i-- > 0 && j-- > 0) res = (parseInt(a.charAt(i), 16) ^ parseInt(b.charAt(j), 16)).toString(16) + res; |
There was a problem hiding this comment.
if the lengths of the chains are different, this will end before they have travelled the longest chain. Is this the desired behaviour?
Update
Related to PB-2666