[PB-2430] fix: allow sharing password deactivation, workspace sharing permissions fixed #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing logic in every guard
apsantiso
had a problem deploying
to
development
GitHub Actions
Failure
apsantiso
had a problem deploying
to
development
GitHub Actions
Failure
apsantiso
force-pushed
the
feat/support-actions-on-sharings-root
branch
from
6b7d161
to
2b3acd4
Compare
apsantiso
had a problem deploying
to
development
GitHub Actions
Failure
apsantiso
force-pushed
the
feat/support-actions-on-sharings-root
branch
from
2b3acd4
to
ac28e4d
Compare
apsantiso
had a problem deploying
to
development
GitHub Actions
Failure
apsantiso
had a problem deploying
to
development
GitHub Actions
Failure
apsantiso
force-pushed
the
feat/support-actions-on-sharings-root
branch
from
864cc6d
to
265a457
Compare
apsantiso
had a problem deploying
to
development
GitHub Actions
Failure
apsantiso
changed the title
apsantiso
changed the title
apsantiso
force-pushed
the
feat/support-actions-on-sharings-root
branch
from
265a457
to
29dff85
Compare
apsantiso
had a problem deploying
to
development
GitHub Actions
Failure
apsantiso
force-pushed
the
feat/support-actions-on-sharings-root
branch
from
29dff85
to
f5aa413
Compare
apsantiso
had a problem deploying
to
development
GitHub Actions
Failure
apsantiso
force-pushed
the
feat/support-actions-on-sharings-root
branch
from
f5aa413
to
56d7e7b
Compare
apsantiso
had a problem deploying
to
development
GitHub Actions
Failure
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on eliminating duplicated data extraction logic in guards and fixing a permissions issue in workspaces. It also adds the option to enable or disable public sharing passwords.
New Decorator for Data Extraction:
Created a decorator to handle data extraction from the request object, so we no longer have to repeat this logic in every guard.
Refactored Extraction Logic:
Moved the extractDataFromRequest logic into a single function, reducing code duplication.
Fixed Permissions Issue:
Permissions are now queried with inner join to retrieve expected results.
Team Sharing:
Updated the sharing navigation to work for multiple teams by removing the dependence on just one teamId in the token.