Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[_]: feat/add-signed-token-on-upload #140

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[_]: feat/add-signed-token-on-upload #140

wants to merge 3 commits into from

Conversation

sg-gs
Copy link
Member

@sg-gs sg-gs commented Nov 29, 2022 •
edited
Loading

  • Adds a signed token to presigned upload URLs

@sg-gs sg-gs marked this pull request as draft November 29, 2022 15:59
fabioespinosa
fabioespinosa suggested changes Nov 29, 2022
View reviewed changes
lib/server/env/index.ts
return {
gateway: {
jwtSecret: process.env.inxtbridge_gateway__JWT_SECRET
},
storage: {
jwtSecret: process.env.inxtbridge_storage__JWT_SECRET
}
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End of file line

lib/server/env/index.ts Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Dec 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #140 (182408d) into master (14871f3) will increase coverage by 0.03%.
The diff coverage is 13.33%.

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
+ Coverage   14.43%   14.46%   +0.03%     
==========================================
  Files          46       46              
  Lines        3110     3124      +14     
  Branches      621      630       +9     
==========================================
+ Hits          449      452       +3     
- Misses       2195     2201       +6     
- Partials      466      471       +5
Impacted Files Coverage Δ
lib/server/env/index.ts 16.66% <0.00%> (+16.66%) ⬆️
lib/core/buckets/usecase.ts 31.48% <15.38%> (+0.03%) ⬆️
lib/server/routes/users.js 0.00% <0.00%> (ø)
lib/server/routes/buckets.js 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabioespinosa fabioespinosa fabioespinosa requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sg-gs @codecov-commenter @fabioespinosa