Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NET-10]: Test/e2e #120

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

[NET-10]: Test/e2e #120

wants to merge 28 commits into from

Conversation

fabioespinosa
Copy link

@fabioespinosa fabioespinosa commented Jul 9, 2022

  • Adds supertest
  • Creates config for e2e tests
  • Creates another validation case for multipart and empty array for uploads in startUpload
  • Adds e2e tests for startUpload, finishUpload and getDownloadLinks (v1 and v2)

Missing: take the bridge up within the tests (right now it points to localhost:6382)

This PR needs to merged first #115 as it fixes some of the issues inside the MongoDB repositories

@fabioespinosa fabioespinosa requested a review from sg-gs July 9, 2022 13:26

const email = '[email protected]';
const password = 'Acvx2.df28dfsZs]';
const hex = crypto.createHash('sha256').update(password).digest('hex');

Check failure

Code scanning / CodeQL

Use of password hash with insufficient computational effort

Password from [an access to password](1) is hashed insecurely.
@fabioespinosa
Copy link
Author

Ready for review @sg-gs

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2022

Codecov Report

Merging #120 (541a8eb) into master (8251bb4) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
- Coverage   14.31%   14.24%   -0.07%     
==========================================
  Files          45       45              
  Lines        3032     3046      +14     
  Branches      614      620       +6     
==========================================
  Hits          434      434              
- Misses       2143     2151       +8     
- Partials      455      461       +6     
Impacted Files Coverage Δ
lib/core/buckets/usecase.ts 31.75% <0.00%> (ø)
lib/server/routes/buckets.js 0.00% <0.00%> (ø)
lib/core/shards/MongoDBShardsRepository.ts 28.12% <0.00%> (-7.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8251bb4...541a8eb. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants