Frontend fixes (#2495)

* fix description * fix id column
intelowlproject · Aug 29, 2024 · 868615c · 868615c
1 parent f750c29
commit 868615c
Show file tree

Hide file tree

Showing 5 changed files with 38 additions and 22 deletions.
diff --git a/frontend/src/components/investigations/table/investigationTableColumns.jsx b/frontend/src/components/investigations/table/investigationTableColumns.jsx
@@ -1,10 +1,10 @@
 /* eslint-disable react/prop-types */
 import React from "react";
+import { UncontrolledTooltip } from "reactstrap";
 
 import {
   DefaultColumnFilter,
   SelectOptionsFilter,
-  LinkOpenViewIcon,
   DateHoverable,
   CopyToClipboardButton,
 } from "@certego/certego-ui";
@@ -24,12 +24,21 @@ export const investigationTableColumns = [
     disableSortBy: true,
     Cell: ({ value: id }) => (
       <div className="d-flex flex-column justify-content-center">
-        <p>#{id}</p>
-        <LinkOpenViewIcon
-          id={id}
+        <a
+          id={`investigation-${id}`}
           href={`/investigation/${id}`}
-          tooltip="View investigation report"
-        />
+          target="_blank"
+          rel="noreferrer"
+        >
+          #{id}
+        </a>
+        <UncontrolledTooltip
+          target={`investigation-${id}`}
+          placement="top"
+          fade={false}
+        >
+          View Investigation Report
+        </UncontrolledTooltip>
       </div>
     ),
     Filter: DefaultColumnFilter,

diff --git a/frontend/src/components/jobs/table/jobTableColumns.jsx b/frontend/src/components/jobs/table/jobTableColumns.jsx
@@ -1,12 +1,11 @@
 /* eslint-disable react/prop-types */
 import React from "react";
-import { Input } from "reactstrap";
+import { Input, UncontrolledTooltip } from "reactstrap";
 import classnames from "classnames";
 
 import {
   DefaultColumnFilter,
   SelectOptionsFilter,
-  LinkOpenViewIcon,
   DateHoverable,
   CopyToClipboardButton,
 } from "@certego/certego-ui";
@@ -35,12 +34,17 @@ export const jobTableColumns = [
     disableSortBy: true,
     Cell: ({ value: id }) => (
       <div className="d-flex flex-column justify-content-center">
-        <p>#{id}</p>
-        <LinkOpenViewIcon
-          id={id}
+        <a
+          id={`job-${id}`}
           href={`/jobs/${id}/${JobResultSections.VISUALIZER}`}
-          tooltip="View Job Report"
-        />
+          target="_blank"
+          rel="noreferrer"
+        >
+          #{id}
+        </a>
+        <UncontrolledTooltip target={`job-${id}`} placement="top" fade={false}>
+          View Job Report
+        </UncontrolledTooltip>
       </div>
     ),
     Filter: DefaultColumnFilter,

diff --git a/frontend/src/components/plugins/types/Pivots.jsx b/frontend/src/components/plugins/types/Pivots.jsx
@@ -20,7 +20,7 @@ export default function Pivots() {
   return (
     <PluginWrapper
       heading="Pivots"
-      description="Pivots are designed to create a job from another job"
+      description="Pivots are designed to create a job from another job."
       stateSelector={stateSelector}
       columns={pivotTableColumns}
       type={PluginsTypes.PIVOT}

diff --git a/frontend/src/components/plugins/types/PluginWrapper.jsx b/frontend/src/components/plugins/types/PluginWrapper.jsx
@@ -82,12 +82,12 @@ export default function PluginWrapper({
             <small className="text-muted">{dataList?.length} total</small>
           </h1>
           <span className="text-muted">
-            {description} Fore more info check the{" "}
+            {description} For more info check the{" "}
             <Link
               to="https://intelowlproject.github.io/docs/IntelOwl/usage/#plugins-framework"
               target="_blank"
             >
-              official doc
+              official doc.
             </Link>
           </span>
         </Col>

diff --git a/frontend/tests/utils/observables.test.js b/frontend/tests/utils/observables.test.js
@@ -69,12 +69,15 @@ describe("Observable validators tests", () => {
     });
   });
 
-  test.each(["test.exe", "test.pdf,", ",test.js,", "256.256.256.256", "google(.)com"])(
-    "test invalid domains (%s)",
-    (valueToValidate) => {
-      expect(observableValidators(valueToValidate)).toBeNull();
-    },
-  );
+  test.each([
+    "test.exe",
+    "test.pdf,",
+    ",test.js,",
+    "256.256.256.256",
+    "google(.)com",
+  ])("test invalid domains (%s)", (valueToValidate) => {
+    expect(observableValidators(valueToValidate)).toBeNull();
+  });
 
   test.each([
     "40ff44d9e619b17524bf3763204f9cbb",