2020 04 20 sync

Agenda

• Opens
• Optimizing LLVM IR for SPIR target - status update from Alexey B.
• Adding SYCL tests in test-suite
• Patches in review for llorg:
  • https://reviews.llvm.org/D71016 - [SYCL] Implement OpenCL kernel function generation
    • Updates from Victor
  • https://reviews.llvm.org/D77220 - [SYCL] Enable OpenCL types required for implementing the SYCL headers.
  • https://reviews.llvm.org/D74387 - [SYCL] Do not diagnose use of __float128
    • Updates from Mariya

Meeting notes

Participants: Alexey Bader (Intel), Mariya Podchischaeva (Intel), Felipe De Azevedo Piovezan (Intel), Victor Lomuller (Codeplay), Hal Finkel (ANL)

• Opens

  • Alexey: SemaSYCL refactoring. https://github.com/intel/llvm/pull/1517. Mariya, could you give a summary of this work, please?

  • Mariya: Existing file is big and complicated. We apply visitor design pattern to simplify the code.

  • Alexey: are you going to move the parts of the code out of this file (e.g. to CodeGen).

  • Mariya: Not with this PR.

  • Address spaces. Bug is submitted. It was confirmed, but no progress so far.

  • Agreed to disable the failing checks and proceed with the patch.

  • Victor, my hack is needed for current implementation and can be removed if we switch to OpenCL attributes.

• Optimizing LLVM IR for SPIR target - status update from Alexey B.

  • https://github.com/intel/llvm/pull/1550
  • SYCL device compiler optimization pipeline is limited to O1 optimizations and they are currently disabled by default as they cause multiple sorts of issues. Some of the issues are addressed within this patch, but not all of them. Optimizations can be enabled with -fsycl-enable-optimizaions front-end option (or -Xclang -fsycl-enable-optimizaions driver option).

• Adding SYCL tests in test-suite

  • Cfe-dev discussion on adding SYCL test to the llvm test-suite project. OpenMP team is working on LIT infrastructure improvement for running tests on accelerators.

• Patches in review for llorg:

  • https://reviews.llvm.org/D71016 - [SYCL] Implement OpenCL kernel function generation
    • Updates from Victor.
    • Victor: There are issues with contributing ComputeCPP compiler attribute to DPC++.
    • Victor: DPC++ compiler handles all argument types differently.
    • Victor: In order to use our attribute we need to unify the was arguments are handled.
    • Victor: We need a unify the way we handle argument types: call init/finalize methods.
    • Victor: ComputeCPP patch will be updated with refactoring.
    • Alexey: Victor, could you comment on the patch with refactoring on how to establish the ABI between the compiler and the runtime, so we can leverage the attribute, please?
    • Victor: okay
  • https://reviews.llvm.org/D77220 - [SYCL] Enable OpenCL types required for implementing the SYCL headers.
  • https://reviews.llvm.org/D74387 - [SYCL] Do not diagnose use of __float128
    • Updates from Mariya. OpenMP needs this as well. It doesn't work ATM. I'll ask additional requirements in review. WIP.