[SYCL][NFC] Drop Gen9 detection from E2E tests #14452
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gen9 HW is not officially supported anymore by our product, we don't have such machines in our CI and therefore it doesn't make sense to keep those legacy LIT features and their usage.
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
commented
Jul 4, 2024
There was a problem hiding this comment.
I'm submitting this as a draft for now to wait for #14451 to reduce amount of conflicts. However, I think that it worth to do an early review of removed files.
@intel/dpcpp-esimd-reviewers, could you please take a look at them? I simply removed them because they require gen9 and nothing else, but I'm not that familiar with ESIMD to say for sure that it was a correct decision and we shouldn't rewrite those tests instead.
There was a problem hiding this comment.
im gonna add new tests for gen12 soon, this test is dead so its okay to remove it
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sarnex
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
im gonna add new tests for gen12 soon, this test is dead so its okay to remove it
againull
approved these changes
Jul 10, 2024
kbenzie
approved these changes
Jul 11, 2024
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
| @@ -13,16 +13,16 @@ | |||
| // RUN: %clangxx -fsycl -fsycl-targets=spir64 %s -o %t.out | |||
| // RUN: %{run} %t.out | |||
|
|
|||
| // RUN: %clangxx -fsycl -fsycl-targets=spir64_gen -Xsycl-target-backend "-device gen9" %s -o %t.out | |||
| // RUN: %clangxx -fsycl -fsycl-targets=spir64_gen -Xsycl-target-backend "-device gen12lp" %s -o %t.out | |||
| // RUN: %{run} %t.out | |||
There was a problem hiding this comment.
Seems to me like this is GPU AOT, so it should be limited to only run on GPU.
Suggested change
| // RUN: %{run} %t.out | |
| // RUN: %if gpu %{ %{run} %t.out %} |
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AlexeySachkov
commented
Sep 20, 2024
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
I cannot approve my own PR, but my comments about recent changes were addressed, so I'm fine with merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gen9 HW is not officially supported anymore by our product, we don't have such machines in our CI and therefore it doesn't make sense to keep those legacy LIT features and their usage.