[SYCL][E2E] Remove uses of OpenCL primitives in Basic/image e2e tests #13998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ayylol One test is failing in CI, could you please take a look. Overall changes look good to me. |
|
I think there is a mistake with git branches/merges/rebases or whatever here... |
asudarsa
reviewed
Jun 5, 2024
| @@ -5843,10 +5843,15 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, | |||
| CmdArgs.push_back("-emit-llvm-uselists"); | |||
|
|
|||
| if (IsUsingLTO) { | |||
| bool IsUsingOffloadNewDriver = | |||
There was a problem hiding this comment.
I think these changes are from a different PR which was recently merged. Can you please sync with SYCL tip? Thanks
asudarsa
reviewed
Jun 5, 2024
| @@ -11120,6 +11125,32 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA, | |||
| for (const auto &A : TranslatorArgs) | |||
| appendOption(OptString, A); | |||
| CmdArgs.push_back(Args.MakeArgString("--llvm-spirv-options=" + OptString)); | |||
|
|
|||
asudarsa
reviewed
Jun 5, 2024
| @@ -1,24 +1,49 @@ | |||
| // REQUIRES: hip | |||
| // RUN: %clangxx -fsycl -fsycl-targets=amd_gpu_gfx906 %s -S -emit-llvm -o - | FileCheck %s --check-prefixes=CHECK,CHECK-SAFE | |||
| // RUN: %clangxx -fsycl -fsycl-targets=amd_gpu_gfx906 %s -mllvm --amdgpu-oclc-unsafe-int-atomics=true -S -emit-llvm -o - | FileCheck %s --check-prefixes=CHECK,CHECK-UNSAFE | |||
| // RUN: %clangxx -fsycl -fsycl-targets=amd_gpu_gfx90a %s -mllvm --amdgpu-oclc-unsafe-fp-atomics=true -mllvm --amdgpu-oclc-unsafe-int-atomics=true -S -emit-llvm -o - | FileCheck %s --check-prefixes=CHECK,CHECK-UNSAFE-FP | |||
There was a problem hiding this comment.
Do we need Compiler Options WG approval for such options? Thanks
asudarsa
reviewed
Jun 5, 2024
| @@ -39,6 +42,9 @@ static cl::opt<bool> | |||
| static cl::opt<bool> AMDGPUUnsafeIntAtomicsEnable( | |||
| "amdgpu-oclc-unsafe-int-atomics", cl::init(false), cl::Hidden, | |||
| cl::desc("Should unsafe int atomics be chosen. Disabled by default.")); | |||
| static cl::opt<bool> AMDGPUUnsafeFPAtomicsEnable( | |||
| "amdgpu-oclc-unsafe-fp-atomics", cl::init(false), cl::Hidden, | |||
| cl::desc("Should unsafe fp atomics be chosen. Disabled by default.")); | |||
There was a problem hiding this comment.
Please consider rewording: Unsafe fp atomics should be chosen.
|
Please resync with sycl branch tip. There are some unrelated changes in this PR. Thanks |
|
Sorry about that, will fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.