va: Add VA_PICTURE_H264_NON_EXISTING flag #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag indicates that the picture is marked as “non-existing” (spec section 8.2.5.2) Signed-off-by: David Rosca <[email protected]>
| * This flag indicates that the picture is marked | ||
| * as “non-existing” (spec section 8.2.5.2) | ||
| */ | ||
| #define VA_PICTURE_H264_NON_EXISTING 0x00000020 |
There was a problem hiding this comment.
dose it mean , you still provide the reference picture ID , but mark it as non-existing?
from my understanding, if there are no reference picture ID, it will be non-existing
There was a problem hiding this comment.
Yes, picture ID is still provided but marked as non-existing. This is what apps currently do, they provide picture ID but the driver has no way knowing it should be non-existing.
It should have the same meaning as Vulkan is_non_existing: https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VkVideoDecodeH264DpbSlotInfoKHR.html#_description
There was a problem hiding this comment.
thanks.
two questions:
- whether it also should be applied to other codec, such as VA_PICTURE_HEVC_XXX
- if application already know it is non_existing, why still provide valid picture_id?
There was a problem hiding this comment.
- There is a similar flag for VVC
VA_PICTURE_VVC_UNAVAILABLE_REFERENCE. Not sure about other codecs (HEVC), currently AMD only supports this for H264 so I wouldn't be able to verify it works as expected. - Applications (ffmpeg/gstreamer) currently provide valid picture_id in this case, so I think this behavior should not change to not break compatibility with drivers not supporting or ignoring this new flag. So the valid picture_id should be provided and additionally the
VA_PICTURE_H264_NON_EXISTINGflag be set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag indicates that the picture is marked
as “non-existing” (spec section 8.2.5.2)
Mesa impl: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31368