Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 3DLUT interpolation method. #767

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FurongZhang
Copy link
Contributor

No description provided.

/** \brief reserved bytes for future use, must be zero */
uint32_t va_reserved[VA_PADDING_HIGH];
uint32_t va_reserved1 : 28;
uint32_t va_reserved[VA_PADDING_HIGH - 1];
} VAProcFilterParameterBuffer3DLUT;

Copy link
Member

@LhGu LhGu Oct 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For HDR10, If app needs to enable 3DLut TETRAHEDRAL interpolation, besides VAProcFilterHighDynamicRangeToneMapping filter type, they also need to add VAProcFilter3DLUT filter type because we only add this parameter in VAProcFilterParameterBuffer3DLUT. right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App either use VAProcFilterHighDynamicRangeToneMapping with HDR10 metadata, or use VAProcFilterParameterBuffer3DLUT by using their own 3DLUT. Those 2 filters are usually not combined to use.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App either use VAProcFilterHighDynamicRangeToneMapping with HDR10 metadata, or use VAProcFilterParameterBuffer3DLUT by using their own 3DLUT. Those 2 filters are usually not combined to use.

Thanks for your answer. For VAProcFilterHighDynamicRangeToneMapping with HDR10 METADATA, do we only control 3DLut interpolation method in our internal driver?
NOW, App only could control interpolation mode by VAProcFilterParameterBuffer3DLUT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants