Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ambiguous warning messages #7

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix ambiguous warning messages #7

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ba1c75
new warning messages
Jun 22, 2022
b95e2b5
code review changes
Jun 28, 2022
a9a6d98
Merge branch 'main' into warning_msgs
LouisdeBruijn Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions spark_matcher/matching_base/matching_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,17 +28,18 @@ def __init__(self, spark_session: SparkSession, table_checkpointer: Optional[Tab
blocking_recall: float = 1.0, n_perfect_train_matches=1, n_train_samples: int = 100_000,
ratio_hashed_samples: float = 0.5, scorer: Optional[Scorer] = None, verbose: int = 0):
self.spark_session = spark_session
self.table_checkpointer = table_checkpointer
if not self.table_checkpointer:
if checkpoint_dir:
self.table_checkpointer = ParquetCheckPointer(self.spark_session, checkpoint_dir,
"checkpoint_deduplicator")
else:
warnings.warn(
'Either `table_checkpointer` or `checkpoint_dir` should be provided. This instance can only be used'
' when loading a previously saved instance.')

if col_names:
if not self.table_checkpointer and checkpoint_dir:
self.table_checkpointer = ParquetCheckPointer(self.spark_session, checkpoint_dir, "checkpoint_deduplicator")
elif table_checkpointer:
self.table_checkpointer = table_checkpointer
else:
warnings.warn(
'Either `table_checkpointer` or `checkpoint_dir` should be provided. This instance can only be used '
'when loading a previously saved instance.')

if col_names and field_info:
raise ValueError("Either `col_names` or `field_info` should be provided.")
elif col_names:
self.col_names = col_names
self.field_info = {col_name: [token_set_ratio, token_sort_ratio] for col_name in
self.col_names}
Expand Down