Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for woe_1d, plus minor cosmetic and test issues #98

Merged
merged 4 commits into from
Jul 6, 2023

Commits on May 24, 2023

  1. Fix for pd.Series input to woe_1d

    The woe_1d function wasn't running y.reset_index() in
    the case where its y input was already a pd.Series. This
    meant that it would return incorrect values when indexes
    in X and y were noncontinuous.
    
    Added a check for this condition to tests/test_metrics.py
    as well.
    lorenjan committed May 24, 2023
    Configuration menu
    Copy the full SHA
    1b74654 View commit details
    Browse the repository at this point in the history
  2. Fix negative IV values in summary tables

    The scikit-learn WOEEncoder uses ln(%bad / %good) instead of
    ln(%good / %bad) for some reason, which flips all of the signs.
    A previous fix switched the computation of WOE in the summary
    table to match. However, this fix caused the IV values to be
    negative in summary tables, which I found surprising.
    
    I added an abs() call to the IV calculation to correct this
    cosmetic defect.
    lorenjan committed May 24, 2023
    Configuration menu
    Copy the full SHA
    9403224 View commit details
    Browse the repository at this point in the history
  3. DataFrame.append was removed in pandas 2.0

    Tests were failing in Pandas 2.0 due to the use of
    DataFrame.append, which has been removed. I fixed it
    by changing this to a pd.concat call.
    lorenjan committed May 24, 2023
    Configuration menu
    Copy the full SHA
    be1705c View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Update branch

    Reinier Koops committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    09ff872 View commit details
    Browse the repository at this point in the history