Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge CustomChoiceGroupMixin with ChoiceGroupMixin #2135

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

merge CustomChoiceGroupMixin with ChoiceGroupMixin #2135

wants to merge 1 commit into from

Conversation

tlouisse
Copy link
Member

@tlouisse tlouisse commented Nov 9, 2023 •
edited
Loading

  • merge CustomChoiceGroupMixin with ChoiceGroupMixin
  • enhance code readibility in multiple components

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 9, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 978cb87

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lion/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tlouisse tlouisse force-pushed the feature-multiselect-multiselect-and-require-option-match-false--enhancements branch 2 times, most recently from 3cca9c8 to c29663e Compare November 9, 2023 15:08
@tlouisse tlouisse force-pushed the feature-multiselect-multiselect-and-require-option-match-false--enhancements branch from c29663e to 978cb87 Compare November 9, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerjanvangeest gerjanvangeest Awaiting requested review from gerjanvangeest gerjanvangeest will be requested when the pull request is marked ready for review gerjanvangeest is a code owner

@narzac narzac Awaiting requested review from narzac narzac will be requested when the pull request is marked ready for review narzac is a code owner

@Knorgias Knorgias Awaiting requested review from Knorgias Knorgias will be requested when the pull request is marked ready for review Knorgias is a code owner

@okadurin okadurin Awaiting requested review from okadurin okadurin will be requested when the pull request is marked ready for review okadurin is a code owner

@ryubro ryubro Awaiting requested review from ryubro ryubro will be requested when the pull request is marked ready for review ryubro is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tlouisse