fix(calendar): focusable disabled dates #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 512aabb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2 tasks
gerjanvangeest
commented
Jun 29, 2023
gerjanvangeest
commented
Jun 29, 2023
Knorgias
force-pushed
the
fix/calendarA11yDisabledDays-rebased
branch
from
7d0815f
to
4cd0116
Compare
gerjanvangeest
commented
Jul 3, 2023
packages/ui/components/calendar/test/lion-calendar.test-backup.js
Outdated
Show resolved
Hide resolved
gerjanvangeest
commented
Jul 3, 2023
packages/ui/components/form-core/src/validate/validators/DateValidators.js
Outdated
Show resolved
Hide resolved
Knorgias
force-pushed
the
fix/calendarA11yDisabledDays-rebased
branch
2 times, most recently
from
621c75b
to
049adf9
Compare
gerjanvangeest
requested review from
tlouisse,
daKmoR,
erikkroes,
ruphin,
narzac,
Knorgias,
whenlit and
DannyMoerkerke
as code owners
gerjanvangeest
commented
Jul 4, 2023
…alendar disabled dates
Knorgias
force-pushed
the
fix/calendarA11yDisabledDays-rebased
branch
from
049adf9
to
512aabb
Compare
Knorgias
approved these changes
Jul 4, 2023
ryubro
reviewed
Sep 6, 2024
| this.centralDate = this.selectedDate; | ||
| } else { |
There was a problem hiding this comment.
@gerjanvangeest I guess you meant to replace this logic with this.findNearestEnabledDate, instead of removing it. I created the PR that does it: #2361
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Rebased version of: #1381
TODO:
Fix: #194