wip

.github/workflows/verify.yml

@@ -17,6 +17,7 @@ jobs:
         uses: actions/setup-node@v4
         with:
           node-version: 18.x
+          cache: 'npm'
 
       - name: Install Dependencies
         run: npm install --ci
@@ -32,10 +33,10 @@ jobs:
   #   runs-on: ubuntu-latest
   #   steps:
   #     - uses: google/wireit@setup-github-actions-caching/v1
-  #     - uses: actions/checkout@v2
+  #     - uses: actions/checkout@v4
 
   #     - name: Setup Node 18.x
-  #       uses: actions/setup-node@v1
+  #       uses: actions/setup-node@v4
   #       with:
   #         node-version: 18.x
 
@@ -62,6 +63,7 @@ jobs:
         uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
+          cache: 'npm'
 
       - name: Install Dependencies
         run: npm install --ci

packages-node/providence-analytics/src/program/utils/optimised-glob.js

@@ -257,16 +257,13 @@ export async function optimisedGlob(globOrGlobs, providedOptions = {}) {
     );
   }
 
-  console.debug({ filteredPaths });
-
   if (options.absolute) {
     filteredPaths = filteredPaths.map(f => path.posix.join(options.cwd, f));
     if (process.platform === 'win32') {
       const driveLetter = path.win32.resolve(options.cwd).slice(0, 1).toUpperCase();
       filteredPaths = filteredPaths.map(f => `${driveLetter}:${f}`);
     }
   }
-  console.debug({ filteredPathsAfterAbso: filteredPaths });
 
   if (options.deep !== Infinity) {
     filteredPaths = filteredPaths.filter(f => f.split('/').length <= options.deep + 2);

packages-node/providence-analytics/test-node/program/utils/optimised-glob.test.js

@@ -196,16 +196,17 @@ describe('optimisedGlob', () => {
   });
 
   describe('Options', () => {
-    it.only('"absolute" returns full system paths', async () => {
+    it('"absolute" returns full system paths', async () => {
       const files = await runOptimisedGlobAndCheckGlobbyParity('my/folder/*/some/file.{js,d.ts}', {
         ...testCfg,
         absolute: true,
       });
 
       if (process.platform === 'win32') {
+        const driveLetter = path.win32.resolve(testCfg.cwd).slice(0, 1).toUpperCase();
         expect(files).to.deep.equal([
-          'D:/fakeFs/my/folder/lvl1/some/file.d.ts',
-          'D:/fakeFs/my/folder/lvl1/some/file.js',
+          `${driveLetter}:/fakeFs/my/folder/lvl1/some/file.d.ts`,
+          `${driveLetter}:/fakeFs/my/folder/lvl1/some/file.js`,
         ]);
       } else {
         expect(files).to.deep.equal([