8549 - Add playwright #1760
Merged
8549 - Add playwright #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmcconechy
requested review from
pwpatton,
bthharper,
boehmd1 and
a team
as code owners
|
Is this also part in the phoenix? |
|
@ericangeles Sort of. We want the tests no matter what as we are going ahead on this repo. But improving test coverage IS part of phoenix. Its just something we can do now anyway without waiting NOTE: Still WIP have some fixes coming |
|
I think this is good for now. Will need in the future to:
|
ericangeles
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the details for making this change. What existing problem does the pull request solve?
Adds playwright and an example test for now. Still kept old karma tests for now until microsoft/playwright#27783 is released and we use that. Means dont write too many karma tests.
DO NOT MERGE: Working on the CI/CD part in this PR>
Related github/jira issue (required):
Fixes infor-design/enterprise#8549
Steps necessary to review your pull request (required):