Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP(iox-10892): patched df upgrade 202-06-03 #25

Closed
wants to merge 3 commits into from
Closed

WIP(iox-10892): patched df upgrade 202-06-03 #25

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23fcaa8
chore: fix `first_value` and `last_value` coercion
appletreeisyellow Jun 10, 2024
93e58e3
Merge commit '59bfe773b61c8bcc83a89502221f849fc12def23' into chunchun…
appletreeisyellow Jun 10, 2024
28282d1
Merge commit '888504a8da6d20f9caf3ecb6cd1a6b7d1956e23e' into chunchun…
appletreeisyellow Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions datafusion/functions-aggregate/src/first_last.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ use datafusion_common::{
arrow_datafusion_err, internal_err, DataFusionError, Result, ScalarValue,
};
use datafusion_expr::function::{AccumulatorArgs, StateFieldsArgs};
use datafusion_expr::type_coercion::aggregates::NUMERICS;
use datafusion_expr::utils::{format_state_name, AggregateOrderSensitivity};
use datafusion_expr::{
Accumulator, AggregateUDFImpl, ArrayFunctionSignature, Signature, TypeSignature,
Expand Down Expand Up @@ -374,7 +373,8 @@ impl LastValue {
vec![
// TODO: we can introduce more strict signature that only numeric of array types are allowed
TypeSignature::ArraySignature(ArrayFunctionSignature::Array),
TypeSignature::Uniform(1, NUMERICS.to_vec()),
TypeSignature::Numeric(1),
TypeSignature::Uniform(1, vec![DataType::Utf8]),
],
Volatility::Immutable,
),
Expand Down