Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2824 - Layer name with special characters causes problems in search #5046

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

#2824 - Layer name with special characters causes problems in search #5046

wants to merge 1 commit into from

Conversation

reckart
Copy link
Member

@reckart reckart commented Sep 7, 2024

What's in the PR

  • Add shortName field to the DB
  • Add shortName field to the AnnotationLayer entity
  • Add mechanism into AnnotaitonLayer entity to fall back to the UIMA short name (i.e. part of name after last dot)
  • Add shortName field to the layer detail form
  • Add validation for the shortName field to ensure it is compatible with the field name conventions required by the index
  • Add shortName to export DTO
  • Use shortName when building the index
  • Should user by able to enter short name manually when creating the layer or should it be derived from the UI name just like the full UIMA name?
  • Should the short name also be used to create the UIMA name instead of deriving the short name from the UI name?

How to test manually

  • TBD

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart reckart added 🐛Bug Something isn't working Module: Project Search labels Sep 7, 2024
@reckart reckart added this to the 35.0 milestone Sep 7, 2024
@reckart reckart self-assigned this Sep 7, 2024
@reckart reckart force-pushed the bug/2824-Layer-name-with-special-characters-causes-problems-in-search branch from 322cdae to bc0c2d9 Compare September 7, 2024 17:27
@reckart
#2824 - Layer name with special characters causes problems in search
2223419 
- Start introducing a "shortName" field in the layer which could be used to configure a name that would be compatible with the index
- Change DB schema
- Started changing layer detail form
- Other stuff still missing
@reckart reckart force-pushed the bug/2824-Layer-name-with-special-characters-causes-problems-in-search branch from bc0c2d9 to 2223419 Compare September 7, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Module: Project Search
Projects
Kanban
Status: No status
Milestone
35.0
Development

Successfully merging this pull request may close these issues.
1 participant
@reckart