Feature/1856 support regex based recommendations #2000
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulled from original-repository to be up-to-date
- Add a first unfinished version of the regex recommender
A first running version
- fix NullPointerException when accepting/rejecting a recommendation
|
Can one of the admins verify this patch? |
- Every RegexRecommender now has its own RegexCounter - fixed some confusing Variable names in RegexCounter
|
Thanks for the PR. I have had a look at the code and it looks quite interesting. You appear to have the need to show a popup as part of accepting an annotation and that currently seems to work only if INCEpTION is run as a standalone version in a graphical desktop environment. This requirement is something I need to think about - i.e. if/how this can be handled in such a way that it works in a purely browser-based environment. |
- fix a few confusing variable names - add a few comments - now the accepted and rejected counts in the regex Counter get incremented when we accept or reject a recommendation
fix a bug that led to NoSuchElementException when accepting or rejecting a recommendation that doesn't come from regexrecommender let the old RegexCounter write its states to the gazeteer when a new RegexCounter is created.
- fix a bug that occured when more than one RegexRecommenders were used at the same time - make sure the gazeteer writes in utf-8 to avoid encoding related bugs - remove some print statements that were used for debugging
…tps://github.com/HerrKrishna/inception into feature/1856-support-regex-based-recommendations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in the PR
How to test manually
Bundestag_08-1.zip