Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: cache DID documents (optional) #105

Merged
merged 17 commits into from
Aug 30, 2024
Merged

perf: cache DID documents (optional) #105

merged 17 commits into from
Aug 30, 2024

Conversation

daniel-mader
Copy link
Contributor

@daniel-mader daniel-mader commented Aug 7, 2024

Description of change

Enables an optional in-memory cache for DID documents (implemented in did-manager). It enhances the speed of interactions for DIDs that need to be resolved from some trusted network.

Enable this feature with caution! Caching DID documents can cause unexpected behavior.

If you decide to enable the cache, you should be aware of the implications and keep the TTL to a minimum.

Links to any relevant issues

n/a

How the change has been tested

Enable the cache with different parameters and exploratively test its behavior.

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have successfully tested this change in a docker environment

@daniel-mader daniel-mader changed the title feat: optional caching of DID documents feat: cache DID documents (optional) Aug 7, 2024
@daniel-mader daniel-mader changed the title feat: cache DID documents (optional) perf: cache DID documents (optional) Aug 7, 2024
@daniel-mader daniel-mader self-assigned this Aug 7, 2024
@daniel-mader daniel-mader added the Enhancement New feature or improvement to an existing feature label Aug 7, 2024
@daniel-mader daniel-mader marked this pull request as ready for review August 29, 2024 21:21
agent_application/Cargo.toml Outdated Show resolved Hide resolved
agent_shared/Cargo.toml Outdated Show resolved Hide resolved
@daniel-mader daniel-mader merged commit 1823810 into dev Aug 30, 2024
1 check passed
@daniel-mader daniel-mader deleted the feat/use-cache branch August 30, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants