-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: cache DID documents (optional) #105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-mader
changed the title
feat: optional caching of DID documents
feat: cache DID documents (optional)
Aug 7, 2024
daniel-mader
changed the title
feat: cache DID documents (optional)
perf: cache DID documents (optional)
Aug 7, 2024
daniel-mader
added
the
Enhancement
New feature or improvement to an existing feature
label
Aug 7, 2024
daniel-mader
force-pushed
the
feat/use-cache
branch
from
August 9, 2024 13:11
1406ba1
to
78578b5
Compare
nanderstabel
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Enables an optional in-memory cache for DID documents (implemented in
did-manager
). It enhances the speed of interactions for DIDs that need to be resolved from some trusted network.Enable this feature with caution! Caching DID documents can cause unexpected behavior.
If you decide to enable the cache, you should be aware of the implications and keep the TTL to a minimum.
Links to any relevant issues
n/a
How the change has been tested
Enable the cache with different parameters and exploratively test its behavior.
Definition of Done checklist
Add an
x
to the boxes that are relevant to your changes.