Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: render embedded images in credential subject #351

Merged
merged 25 commits into from
Sep 18, 2024
Merged

feat: render embedded images in credential subject #351

merged 25 commits into from
Sep 18, 2024

Conversation

daniel-mader
Copy link
Collaborator

@daniel-mader daniel-mader commented Aug 30, 2024 •
edited
Loading

Description of change

Render all credentialSubject claims that start with data:image/ as an <img /> instead of displaying them as regular text fields.

Links to any relevant issues

How the change has been tested

Visual inspection in Desktop mode.

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@daniel-mader daniel-mader self-assigned this Aug 30, 2024
@daniel-mader daniel-mader added the Added A new feature that requires a minor release. label Aug 30, 2024
@daniel-mader daniel-mader added the Blocked An issue that is blocked by another issue or another blocker. label Sep 3, 2024
@daniel-mader
Copy link
Collaborator Author

Blocked by #284

@daniel-mader daniel-mader changed the base branch from dev to maiertech/issue284 September 16, 2024 09:14
Base automatically changed from maiertech/issue284 to dev September 17, 2024 15:47
@daniel-mader daniel-mader removed the Blocked An issue that is blocked by another issue or another blocker. label Sep 17, 2024
maiertech
maiertech requested changes Sep 17, 2024
View reviewed changes
Copy link
Member

@maiertech maiertech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the image renderer be more robust to images with different aspect ratios?

maiertech
maiertech approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@maiertech maiertech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the image renderer be more robust to images with different aspect ratios?

@daniel-mader daniel-mader merged commit 5f29c21 into dev Sep 18, 2024
3 checks passed
@daniel-mader daniel-mader deleted the feat/subject-embedded-images branch September 18, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maiertech maiertech maiertech approved these changes

@nanderstabel nanderstabel nanderstabel approved these changes

Assignees

@daniel-mader daniel-mader

Labels
Added A new feature that requires a minor release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for credential embedded images
3 participants
@daniel-mader @maiertech @nanderstabel