refactor: Wire up Tauri listeners in onMount of root layout
#322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiertech
changed the title
onMount of root layout
maiertech
force-pushed
the
maiertech/issue246
branch
from
5edf4ac
to
c38a7ed
Compare
daniel-mader
approved these changes
Aug 27, 2024
Oran-Dan
approved these changes
Aug 28, 2024
Oran-Dan
added a commit
that referenced
this pull request
Aug 30, 2024
* ci: release version 0.6.8 (#346) * fix: bindings * feat: add default_trust_list.json * test: add testing, not final * feat: enable multiple trust lists * chore: remove comment * refactore: rename actions and reducers * feat: add TrustList level actions * refactor: trustlist owned bool, name to id, reset to default * chore: fix domain name * feat: add trust list management frontend * refactor: implement lists view & domain list * refactor: Wire up Tauri listeners in `onMount` of root layout (#322) * Wire up Tauri state-changed listener in `onMount` of root layout * Wire up Tauri error listener in root layout * Update comments * build: Replace `npm` with `pnpm` (#348) * Swap out `npm` for `pnpm` Fixes #347 * Address review comments * chore: cargo fmt and fix binding naming * feat: prevent edits on imported lists * refactor: remove unused reset functionality * feat: add placeholder when no lists * refactor: trustlist actions * refactor: remove trustlist default impl * refactor: use updated Action names * fix: rename broken bindings * refactor: remove `Default` trait * refactor: show `display_name` instead of `id` * feat: update default trusted domains --------- Co-authored-by: Daniel Mader <[email protected]> Co-authored-by: Thilo Maier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Since #246 popped up twice recently, this PR refactors how the backend state is passed into the frontend state.
Instead of wiring Tauri listeners up when corresponding states get their first subscriber, now the listeners are wired up in the
onMountof the root layout. This is the only component that is guaranteed to exist at any time while UniMe is open.It's not clear if this will fix #246. If nothing else, this refactoring makes it cleaner and easier to understand where the Tauri listeners are wired up.
Links to any relevant issues
How the change has been tested
devand observing over a longer period if Wrong route gets served #246 occurs again.Definition of Done checklist
Add an
xto the boxes that are relevant to your changes.