Add x86_64 and x86-64 aliases for x64
#44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By a popular request...
|
(Okay, let's see what happens if I don't say “closes” in the PR, but manually add an issue to the linked list...) |
Yes, it works as expected. |
pzhlkj6612
reviewed
May 29, 2021
| - `x64` (default) or its synonyms: `amd64`, `win64` | ||
| - `x64` (default) or its synonyms: `amd64`, `win64`, `x86_64` |
There was a problem hiding this comment.
Well, you forgot "x86-64".
There was a problem hiding this comment.
Right 👍 Thanks. I've added it to the README as well (without a PR, minor doc change after all).
It seems we've opened a hole to hell with these aliases...
There was a problem hiding this comment.
Yes.
After a month, you may forget the difference between "x86_64", "x86_amd64" and "amd64" ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By a popular request...
References: #39
x86_64is the one that was requested, but sure as hell there are people who'd likex86-64as well.