Add log scale feature to negative values in WIG track #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Another PR related to WIG tracks, this time related to log scale and negative values. As I've seen this has not been covered yet in either the JS or desktop version with negative values just being represented as 0. In my mind it makes sense to do the same thing as with the positive values and just represent it "under the line" i.e. as a negative value. I hope this makes sense to you as well.
The result can be seen in the screenshots below.
This first set represents a merged track with two bigwig files which have opposite values
Regular scale:
Log scale:
This one is a single bigwig file with positive and negative values in it
Regular scale:
Log scale:
There was another minor fix related to accounting for y coordinates being 0 based which mostly influences the "line" style of the WIG track. Is there any reason for line not being documented? It was a bit buggy with the SVG output previously but with recent work on the saving to SVG it seems to be working fine. Maybe we could document it together with "points" and "bar"?