Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt plugincache MergeStrategy to sbt-assembly:2.0.0 #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fnqista
Copy link

@fnqista fnqista commented May 4, 2022

Update MergeStrategy code to use temp files to extract the InputStreams
Update the sbt assembly plugin to use 2.0.0-RC1
Update the log4j version to 2.17.2
Update version to 2.1.0


Hey maintainers,

We need to update this for the upcoming sbt-assembly 2.0.0 (right now it's in RC1 mode)

Background

sbt-assembly has recently been updated to use a streaming/in-memory model instead of IO/disk-extraction model. Due to this, the method signature of the MergeStrategy has changed.

I also went ahead and updated the log4j dependency to 2.17.2 to fix that infamous vulnerability.

Update MergeStrategy code to use temp files to extract the InputStreams
Update the sbt assembly plugin to use 2.0.0-RC1
Update the log4j version to 2.17.2
Update version to 2.1.0
@mpollmeier
Copy link

Thank you for this PR. The project seems unmaintained, so I took the liberty to fork it, include your PR, upgrade everything and release it to maven central. I added you to the https://github.com/mpollmeier/sbt-assembly-log4j2#credits and hope that's ok?

https://github.com/mpollmeier/sbt-assembly-log4j2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants