Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2 replace logs with @idearium/log #310

Merged
merged 3 commits into from
Feb 15, 2023
Merged

#2 replace logs with @idearium/log #310

merged 3 commits into from
Feb 15, 2023

Conversation

allanchau
Copy link
Member

@allanchau allanchau commented Dec 2, 2022

This PR removes the Idearium-lib logger and replaces all logs within the legacy library with the new @idearium/log package.

Related PRs

Notes

  • The log-request and log-error middleware has also been removed since we have new packages for that.
  • DEBUG has been replaced with log.info
  • This PR needs to be updated with the related logging PR once that is released.

Verification and testing

Testing

  • Add this pr to a project.
  • Remove the log directory if it exists.
  • Fix up any legacy logrequest/logerror middleware if they exist.
  • Update the manifests with the environment variables defined here
  • Start the project, logs should still be coming through and everything should work as it did before.

@allanchau allanchau requested a review from a team December 2, 2022 01:34
@allanchau allanchau assigned allanchau and smebberson and unassigned allanchau Dec 2, 2022
@allanchau allanchau marked this pull request as ready for review December 5, 2022 22:53
@allanchau allanchau mentioned this pull request Dec 5, 2022
8 tasks
@allanchau allanchau changed the title replace logs with @idearium/log #2 replace logs with @idearium/log Dec 5, 2022
Copy link
Member

@smebberson smebberson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allanchau, looks good, lets do a full major release and start working this new version bump back through the projects that reference this branch via a commit SHA.

@allanchau allanchau merged commit cef1ab7 into legacy Feb 15, 2023
@allanchau allanchau deleted the remove-log-legacy branch February 15, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants