Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-6202: Fixed url alias grouping #248

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

kisztof
Copy link
Contributor

@kisztof kisztof commented Jul 25, 2023

Question Answer
JIRA issue IBX-6202
Type bug
Target Ibexa version v4.6
BC breaks no

This PR fixes URL alias grouping.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@kisztof kisztof force-pushed the hotfix/IBX-6202-fixed-grouping branch from 3901e2f to 56573bc Compare July 25, 2023 11:56
@kisztof kisztof requested a review from a team July 25, 2023 11:56
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kisztof we also need to makes sure that it works on the integration level. We can change a bit UrlAliasLookupTest to accept data provider which defines URL Alias name schema, input names, and expected URL Alias. createFolder would have to be replaced by some custom Content Type so you can set URL Alias name schema.
Alternatively instead of lookup the test can simply load system (auto-generated) URL Aliases and check if the path is correct.

Can be done as a follow-up to speed up QA on this PR.

@alongosz alongosz requested a review from a team July 25, 2023 12:28
@alongosz alongosz changed the title IBX-6202 Fixed url alias grouping IBX-6202: Fixed url alias grouping Jul 25, 2023
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine now, thanks!

QA Approved on Ibexa Commerce 4.6.0-dev.

@micszo micszo removed their assignment Jul 26, 2023
@alongosz alongosz merged commit 3adc2af into main Jul 27, 2023
24 of 26 checks passed
@alongosz alongosz deleted the hotfix/IBX-6202-fixed-grouping branch July 27, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants