Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tablet] Allow mapping to entire monitor layout #7586

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Agent00Ming
Copy link
Contributor

@Agent00Ming Agent00Ming commented Aug 30, 2024

Describe your PR, what does it fix/add?

Fixes #6023.
Moves monitor layout entire area search to a function and enables tablets to map to the entire monitor layout. This allows OpenTabletDriver's monitor mapping settings to work on artist mode.

Optionally enabled via input:tablet:output = entire

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Tested working with OTD on artist mode. Does not work with OTD absolute mode (virtual device is listed alongside normal mice in hyprctl devices). Related: #6889

Is it ready for merging, or does it need work?

Ready.

@Stoppedpuma
Copy link

This doesn't seem to work correctly in applications. On the desktop it seems to work fine though.

1725034082.webm

@Agent00Ming
Copy link
Contributor Author

Agent00Ming commented Aug 30, 2024

Well what about everything except osu? Because it seems like it grabs the input for itself once focused. Cursor lock -> tablet input redirected to cursor lock region it seems.

@Stoppedpuma
Copy link

Stoppedpuma commented Aug 30, 2024

I can't seem to reproduce this outside of osu! but I also don't really have many applications to test with. My guess on why this happens is Hyprland isn't resizing the window correctly, usually when resizing osu! it will show a toast with the new resolution, this doesn't seem to happen under Hyprland for some reason.

Resize toast example in Sway:

1725036452.mp4

@Agent00Ming
Copy link
Contributor Author

The resolution change toast not appearing is somewhat unrelated. Tablet input mapping to cursor lock region could be changed another day as it's not the focus of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tablet no longer maps to area correctly
2 participants