Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resize artifacts (stretching, bumps) #7499

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix resize artifacts (stretching, bumps) #7499

wants to merge 3 commits into from

Conversation

vaxerski
Copy link
Member

@vaxerski vaxerski commented Aug 24, 2024

WIP

Fixes resize artifacts notably when using the mouse to resize apps to larger sizes (stretching etc)

ref #7475

@vaxerski vaxerski marked this pull request as ready for review August 24, 2024 15:05
@vaxerski
Copy link
Member Author

ready for review

@diniamo
Copy link
Contributor

diniamo commented Aug 24, 2024

Um, I don't see a difference.

@vaxerski
Copy link
Member Author

well I surely do, mind to get a recording?

@MahouShoujoMivutilde
Copy link
Contributor

MahouShoujoMivutilde commented Aug 24, 2024

Definitely can see the improvement.

no-patch-foot-no-anim.mp4

And with patch

patch-foot-no-anim.mp4

Notice no bg flash on the left window.

@diniamo
Copy link
Contributor

diniamo commented Aug 25, 2024

Oh, that's the only thing I wasn't looking at. A lot of the other problems are still there though.

@vaxerski
Copy link
Member Author

image
this frame is odd, as the patch should expand the texture along the edges. What's that terminal and what settings?

@MahouShoujoMivutilde
Copy link
Contributor

It's because its 1.25 monitor scale, can't reproduce on 1

Foot on defaults (with my bindings and colors), and hyprland now with hdefault-min.conf.txt

@ferrreo
Copy link
Contributor

ferrreo commented Aug 25, 2024

This patch does this to my wallpaper at 1.25 scaling:
image

Other than that and not fixing Electron resizing artifacts it does seem to fix stretching etc overall when resizing other things.

@vaxerski
Copy link
Member Author

looks very nice.

@vaxerski
Copy link
Member Author

can't repro, what wallpaper daemon?

@ferrreo
Copy link
Contributor

ferrreo commented Aug 25, 2024

can't repro, what wallpaper daemon?

hyprpaper,

For more useful repro steps, it's a 4k wallpaper at 3440x1440 resolution @165hz for monitor config with 1.25 fractional scaling.

@Agent00Ming
Copy link
Contributor

Used it for a while, can't really tell the difference tbh. No noticeable problems have come up either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants